481739 - firstrun_splash.png eats startup time

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(dormant account)]

tried converting that file to a gif, saved at least half a second.

Comment 1

[(dormant account)]

pngcrush does not help much, still about 50times slower than gif according to my measurements

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I wonder what we could do in the PNG decoder to make things faster. We favor PNG for all our UI images.

But yeah, we could certainly change that one.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: current image - for reference

Comment 4

[Sean Martell]

Attachment: New Splash page

I've rebuilt the page, using a new, smaller background + PNG.  PNG 8-bit saved smaller than GIF in PS.

We've gone from 264Kb of images to 48kb.

Comment 5

[Sean Martell]

Attachment: New Splash GIF

revised Splash GIF. 

Simply update index.html to reflect extension change.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch:

* adds the new firstrun_splash.gif and firstrun_background.gif files
* removes the DTD
* moves CSS into the firstrun.xhtml file
* removes the CSS file
* changes the <title> to "Fennec"
* makes the changes to both hildon and wince themes

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: removes DTD from locale jar.mn

I forgot to remove the DTD from the locale jar.mn

Comment 8

[(dormant account)]

you also need to rename xhtml -> html to avoid loading xhtml dtd

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: xhtml -> html

renames the firstrun.xhtml to firstrun.html

Comment 10

[(dormant account)]

I'm sorry, the xhtml dtd is still being loaded, damned if I know why. I remember trying to debug this before and giving up. I think that dtd is in a jar, so it should be fast to load.

I sliced off a pixel from width on _splash.gif and the black line rounding bug went away for default res(heh!).

The font css is redundant, I don't see any diff when I remove the rest of css too.

Comment 11

[(dormant account)]

also, I don't think the absolute filenames are needed.

Comment 12

[(dormant account)]

Attachment: trimmed gif

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: new image and aboutFirstrun fixed

this patch adds Taras' new image (hides rounding problem) and corrects aboutFirstrun.js

This is the one for b1!

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/cf3d823f5ed3

Comment 15

[Axel Hecht [:Pike]]

Any idea how this is supposed to be be localized now?

Comment 16

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #15)
> Any idea how this is supposed to be be localized now?

The new image has the same text as the old image. "Welcome to Fennec" (the "Welcome to" is white)

So we are no worse off than before. However, we do need a plan for localizing it. We could always drop the "Welcome to" part as well.

Comment 17

[Brad Lassey [:blassey] (use needinfo?)]

can the text be made part of the html page?

Comment 18

[Axel Hecht [:Pike]]

We shouldn't make html part of l10n, but we could post-process something with a foo.inc file.

Comment 19

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #18)
> We shouldn't make html part of l10n, but we could post-process something with a
> foo.inc file.

Agreed. I was going to suggest that, but was afraid you would yell at me :)